[dist/eui_charts_theme.d.ts] incorrect import module name#3492
Merged
thompsongl merged 3 commits intoelastic:masterfrom May 18, 2020
Merged
[dist/eui_charts_theme.d.ts] incorrect import module name#3492thompsongl merged 3 commits intoelastic:masterfrom
thompsongl merged 3 commits intoelastic:masterfrom
Conversation
chandlerprall
approved these changes
May 16, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Well that's annoying. I'll slot revisiting the TS build stuff in 7.10
Contributor
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3492/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3492/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding the
RecursivePartialimport statement insrc/themes/charts/themes.tsresults in an incorrect TS module reference in the generated.d.tsfile ('@elastic/eui/components/common').The real module name (in
eui.d.ts) is'@elastic/eui/src/components/common'.This definition file has its own
dtsGeneratormethod and the pathing is odd given its location in the directory. Open to other suggestion, also.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes