[EuiSuperDatePicker] date popover onChange should only accept strings#3460
Merged
thompsongl merged 6 commits intoelastic:masterfrom May 14, 2020
Merged
[EuiSuperDatePicker] date popover onChange should only accept strings#3460thompsongl merged 6 commits intoelastic:masterfrom
thompsongl merged 6 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3460/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3460/ |
anishagg17
reviewed
May 12, 2020
src/components/date_picker/super_date_picker/date_popover/absolute_tab.tsx
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3460/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3460/ |
chandlerprall
approved these changes
May 14, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM. Tested manual entry in the Absolute tab and it's not broken anymore 🎉
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3460/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual datetime entry via the input in the 'Absolute' tab would result in a Moment object being passed up through the component and causing errors. The the
onChangeevent parameter for date_popover_content was mistyped as allowing Moment objects when in all cases the value is treated as astring.This restricts the interface to the expected
stringtype and uses an ISO string in place of the full Moment object.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes