[EuiSuperDatePicker] Quick select menu inherits selected value (again)#3446
Merged
thompsongl merged 3 commits intoelastic:masterfrom May 11, 2020
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3446/ |
chandlerprall
approved these changes
May 11, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Confirmed functionality is back to what is expected in the PR deploy
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3446/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes from #3105 were lost in the TypeScript conversion of EuiSuperDatePicker and friends. Probably just an upstream merge error as they were both in flight at about the same time.
This restores the ability for the quick select menu to inherit the value in the start-end selection popovers using the
parseTimePartsutil.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes