Skip to content

Added utcOffset prop to EuiSuperDatePicker#3436

Merged
thompsongl merged 7 commits intoelastic:masterfrom
anishagg17:utc
May 11, 2020
Merged

Added utcOffset prop to EuiSuperDatePicker#3436
thompsongl merged 7 commits intoelastic:masterfrom
anishagg17:utc

Conversation

@anishagg17
Copy link
Copy Markdown
Contributor

@anishagg17 anishagg17 commented May 7, 2020 •
edited
Loading

Summary

Closes: #3433

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox

  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 7, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17 anishagg17 changed the title added EuiSuperDatePicker UTC offset prop Added utcOffset prop to EuiSuperDatePicker May 7, 2020
@elizabetdev
Copy link
Copy Markdown
Contributor

elizabetdev commented May 7, 2020 •
edited
Loading

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 7, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3436/

@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented May 7, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented May 7, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3436/

thompsongl
thompsongl reviewed May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @anishagg17

Theoretically this is exactly correct, but I can't seem to find proof that the utcOffset prop does anything at all in EuiDatePicker. I'm going to do more research and let you know what I find.

@thompsongl thompsongl mentioned this pull request May 7, 2020
Closed
thompsongl
thompsongl approved these changes May 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is safe to merge. I'm going to open a new issue to triage utcOffset prop at a lower level.

@thompsongl thompsongl merged commit 378f8dc into elastic:master May 11, 2020
@thompsongl thompsongl mentioned this pull request May 11, 2020
Closed
@anishagg17 anishagg17 deleted the utc branch May 12, 2020 08:09
@thompsongl thompsongl mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thompsongl thompsongl thompsongl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EuiSuperDatePicker UTC offset

4 participants

@anishagg17 @kibanamachine @elizabetdev @thompsongl