[EuiBasicTable] Move to next-to-last page if all items of last pages are deleted.#3431
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Just for docs accessibility, when the delete button disappears can we place the user's focus somewhere on the page? The checkbox in the table header is a good option. |
|
@myasonik Thanks for the suggestion. I will move the focus to the checkbox in the table header. |
@myasonik I can't find a method to do that without modifying the |
|
Bleeeh, I forgot that forwarding refs is kind of a whole thing... I've got a PR that I'm hoping to get back to soon that deals with some similar issues for navigation so I can tackle it then. Feel free to skip this. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3431/ |
|
@chandlerprall Thank you for the review. Changes committed 👍 |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Tested the selection example for basic & in-memory tables and they both work as expected. Will merge on green CI
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3431/ |
Summary
Fixes #3422
Before
After
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes