Add caching layer to EuiIcon#3404
Merged
chandlerprall merged 4 commits intoelastic:masterfrom Apr 30, 2020
Merged
Conversation
…ly renderable values
b34b2cf to
836bd84
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3404/ |
thompsongl
approved these changes
Apr 29, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
🎉
Ran jest tests a few times with no surprises.
Spot-checked EUI docs examples, page transitions for visual flicker without surprises.
LGTM
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3404/ |
cchaos
approved these changes
Apr 30, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Functionally works for me 👍
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3404/ |
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3393
Added a caching layer and some other logic to avoid fading in icons when they are immediately renderable.
euiIcon-isLoadedclass when an icon is immediately renderable, removing the fade-in animation on cached icons or when a custom component is providedThe various update paths for the icon's state is definitely a mess. Everything's working, rendering, and snapshotting as expected but the next time the maze is touched it should be documented & refactored.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes