[EuiCard] Allow custom component for image prop#3370
Merged
cchaos merged 11 commits intoelastic:masterfrom Apr 23, 2020
Merged
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
fd483b2 to
e16b8df
Compare
cchaos
reviewed
Apr 22, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
🎉 Thanks @TAYTS .
Just a could suggestions. Also, can you update one of the image cards to pass a custom element. It can just be as simple as:
<EuiCard
image={<div><img src="...unsplash source url..." /></div>}
...rest of the props...
</EuiCard>
Contributor
|
J, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3370/ |
Contributor
|
retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue: #3341
Added
ReactElementto theEuiCardimageprop to allow passing custom component.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in IE11 and Firefox- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes