Add overflow to datagrid toolbar dropdowns#3238
Merged
snide merged 6 commits intoelastic:masterfrom Apr 3, 2020
Merged
Conversation
snide
commented
Apr 3, 2020
| - Updated pagination prop descriptions for `EuiInMemoryTable` ([#3142](https://github.com/elastic/eui/pull/3142)) | ||
| - Added `title` and `aria` attributes to `EuiToken`'s icon element ([#3195](https://github.com/elastic/eui/pull/3195)) | ||
| - Added new Elasticsearch token types ([58036](https://github.com/elastic/kibana/issues/58036)) | ||
| - Added new Elasticsearch token types ([#2758](https://github.com/elastic/eui/pull/2758)) |
Contributor
Author
There was a problem hiding this comment.
Small CL fix unrelated to this PR.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3238/ |
cchaos
reviewed
Apr 3, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3238/ |
cchaos
approved these changes
Apr 3, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
CL nit, but overall LGTM! 👍 Thanks for fixing the buttons too.
Contributor
Author
|
Changes made. Merging on green. @peteharverson can you let us know whether you consider this fix necessary for a backport for 7.7? |
chandlerprall
approved these changes
Apr 3, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3238/ |
|
Looks great. Thanks for getting in this fix @snide. I am happy to leave this for 7.8 - the current control in 7.7 is usable, just the UX is not that great when you have 100s of columns in the grid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3209
Adds an overflow to a couple of the popovers in Data Grid to fix instances where there are lots of columns.
Checklist
Props have proper autodocsAdded documentation examplesChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes