EuiCodeEditor now assigns correct attributes to textarea#3212
Merged
thompsongl merged 5 commits intoelastic:masterfrom Apr 6, 2020
Merged
EuiCodeEditor now assigns correct attributes to textarea#3212thompsongl merged 5 commits intoelastic:masterfrom
textarea#3212thompsongl merged 5 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
textarea
Contributor
Author
|
There are still some ts-errors, will resolve them soon |
Contributor
Author
|
This PR is now ready for review, ts-errors errors have been fixed |
myasonik
approved these changes
Apr 2, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
Tested locally and everything seems to work well!
Contributor
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3212/ |
thompsongl
approved these changes
Apr 6, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @anishagg17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2961 , #2960
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes