Fixed EuiSuperDatePicker "End date" popover shows wrong relative time#3132
Merged
thompsongl merged 2 commits intoelastic:masterfrom Mar 24, 2020
Merged
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3132/ |
thompsongl
approved these changes
Mar 24, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Thanks! This looks good.
I think there would be ways to prevent from converting to absolute format each time, but the later-used parseRelativeParts function largely handles the complexity and prevents some very specific branches from appearing earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Possible Fix for: #3131
The "End date" popover shows the same relative time as the "Start date" popover. This can be solved by converting the value on relative tab to absolute string using toAbsoluteString function
Before:
After:
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests