Fix race condition in EuiIcon's internal setState#3118
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Mar 18, 2020
Merged
Fix race condition in EuiIcon's internal setState#3118chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall merged 2 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3118/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3118/ |
paul-tavares
approved these changes
Mar 18, 2020
paul-tavares
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the quick attention to this. Really appreciate it.
Contributor
Author
|
jenkins test this flaky test |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3118/ |
thompsongl
approved these changes
Mar 18, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
👍 Thanks, @chandlerprall
Contributor
|
@paul-tavares Is this something you need for 7.7, or will 7.8 be ok? |
|
@snide yeah, we have been backporting to 7.x (currently 7.7), so if you can get it there, that would be great. Once done, I will go back to our current implementation and add back in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3113
Reproduced the issue in the Kibana branch as described. Copied code to EUI's docs to boil it down to a basic use case, and found:
empty, which triggers a dynamic fetch for the empty iconimgelement created, network request madeAfter making this change in EUI & confirming it fixed my simplified test case, I built EUI with the change and dropped it into the above Kibana branch, confirming it resolves the issue there too.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes