added correct aria for Version#3080
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@eui-team Thoughts on changing up this area a bit? It took me the longest time to figure out that the version number and the icon lined to different things. Maybe something like: |
That makes sense to me. I hadn't noticed that the links go to different locations 😄 |
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3080/ |
|
@anishagg17 Can you also add my suggestion from above before merging? Restructuring a couple elements to read:
Should look like this after (just did this in browser dev tools): |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3080/ |
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3080/ |
Summary
Fixes: #623
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] A changelog entry exists and is marked appropriately