removed ghost "Show component code" button#3078
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| <EuiButton> | ||
| <Link to={componentLinkTo}>View component code</Link> | ||
| </EuiButton> |
There was a problem hiding this comment.
Nesting a link inside a button is about the same as nesting a button inside a link so I'm afraid this doesn't really solve the problem...
Maybe the EUI team has some guidance on how to use react-router with EuiButton?
There was a problem hiding this comment.
I've added a discussion item for our Tuesday weekly since I've run into this in consuming apps as well.
There was a problem hiding this comment.
@anishagg17 Can you try this technique of using React router with EuiButton https://github.com/elastic/eui/blob/master/wiki/react-router.md#1-conversion-function-recommended
|
Now the highlighting goes away
as it was before
|
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3078/ |
thompsongl
left a comment
There was a problem hiding this comment.
Can you try this technique of using React router with EuiButton?
This would be the ideal method, but we don't actually have the requisite services as part of the EUI docs site (🤷♂)
As is, this PR will work. I can do a follow-up PR to introduce the necessary routing services to allow for accessing getRouterLinkProps
Summary
Fixes: #696
"ghost" Show Component Code button is removed, on first tab "Show component code" but is active
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] A changelog entry exists and is marked appropriately