Upgrade react-beautiful-dnd to v13#3064
Conversation
…-dnd to 11.0.0; Changed the tests for: draggable.tsx, droppable.tsx, drag_drop_context.tsx
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
@chandlerprall I have now uploaded the version with the issue. |
|
@LeonY1 pushed directly to your branch to get those tests fixed:
|
|
Okay thanks for the help! |
|
@chandlerprall This should be ready to be merged. Let me know if I need to fix anything extra |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3064/ |
thompsongl
left a comment
There was a problem hiding this comment.
This is great!
Tested functionality and everything appears to be in order.
With the move from dependencies to peerDependecies, this constitutes a breaking change. We'll need to mark it so in the changelog
|
@thompsongl I have moved it to the Breaking Changes section. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3064/ |
|
After more investigation, we're not going to make RBD a peerDep. I'll update the branch for you, @LeonY1, as I lead you down the wrong path. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3064/ |
thompsongl
left a comment
There was a problem hiding this comment.
Thanks for your work on this, @LeonY1!
Summary
Closes #2427
I am updating the react-beautiful-dnd and @types/react-beautiful-dnd dependencies.
Checklist