Skip to content

Automated Axe testing#3035

Merged
snide merged 3 commits intoelastic:masterfrom
mridulgogia:axe-tests
Mar 11, 2020
Merged

Automated Axe testing#3035
snide merged 3 commits intoelastic:masterfrom
mridulgogia:axe-tests

Conversation

@mridulgogia
Copy link
Copy Markdown
Contributor

Summary

Makes progress on #2679
Automated Axe testing

Utilities

  • Accessibility
  • Context
  • Copy
  • Delay Hide (none)
  • Delay Render (none)
  • Highlight

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for making progress on this huge ticket!

Just some small edits to clean it up a bit. :)

Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By accident hit approve instead of request changes - sorry!

@myasonik
Copy link
Copy Markdown
Contributor

jenkins test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_3035/

@snide snide merged commit f416a41 into elastic:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants