Skip to content

Performed axe-testing for form_layouts and range#3004

Merged
cchaos merged 12 commits intoelastic:masterfrom
anishagg17:acce
Mar 10, 2020
Merged

Performed axe-testing for form_layouts and range#3004
cchaos merged 12 commits intoelastic:masterfrom
anishagg17:acce

Conversation

@anishagg17
Copy link
Copy Markdown
Contributor

@anishagg17 anishagg17 commented Mar 8, 2020 •
edited
Loading

Summary

Makes progress on #2679

Pages

Forms :

  • Form Layouts
  • Range Sliders
  • Loading
  • Progress

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately

  • Checked for accessibility including keyboard-only and screenreader modes
    - [ ] A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 8, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 8, 2020 •
edited
Loading

Thanks for getting this started!

Two broad pieces of feedback:

  • Could you please push these pages onto the array to get tested? (Feel free to push arbitrary pages onto that array, it doesn't have to continue to go in order.)
    • You mention in the issue that Loading and Progress already pass as well, do you want to add those as well to your work here?
  • Could you change the aria-label values you added to be human readable strings? (An aria-label serves the same purpose as a visual label for when one doesn't exist.)

myasonik
myasonik reviewed Mar 8, 2020
View reviewed changes
@myasonik myasonik mentioned this pull request Mar 8, 2020
Closed
26 tasks
@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Mar 9, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 9, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3004/

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 9, 2020

@anishagg17 I don't know if you're still working on this, but just a reminder that these pages still need to be added to the automation script for them to be tested in CI.

You can add them by mutating this array to include the pages you checked and fixed.

@anishagg17
Copy link
Copy Markdown
Contributor Author

anishagg17 commented Mar 9, 2020

@myasonik I knew that i have to mutate the array . I will surely do that with in an hour

myasonik
myasonik reviewed Mar 9, 2020
View reviewed changes
@anishagg17
Copy link
Copy Markdown
Contributor Author

anishagg17 commented Mar 9, 2020

@myasonik I have updated it

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 9, 2020

jenkins test this

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 9, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3004/

myasonik
myasonik approved these changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all your work here @anishagg17!

cchaos
cchaos suggested changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have some grammar change requests

anishagg17 and others added 6 commits March 10, 2020 20:13
@anishagg17 @cchaos
Update src-docs/src/views/form_layouts/full_width.js
93d021b 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17 @cchaos
Update src-docs/src/views/range/states.js
f6c96a6 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17 @cchaos
Update src-docs/src/views/range/ticks.js
1ed9297 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17 @cchaos
Update src-docs/src/views/range/ticks.js
6d2e98a 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17 @cchaos
Update src-docs/src/views/range/ticks.js
67967fe 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17 @cchaos
Update src-docs/src/views/range/states.js
52f6b4a 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@anishagg17
Copy link
Copy Markdown
Contributor Author

anishagg17 commented Mar 10, 2020

All Done @cchoas 👍

@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Mar 10, 2020

jenkins test this

cchaos
cchaos reviewed Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack sorry, found one more problem

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 10, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3004/

@anishagg17 @cchaos
Update src-docs/src/views/range/input.js
8670d3e 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Mar 10, 2020

jenkins test this

cchaos
cchaos approved these changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go when CI is green

@kibanamachine
Copy link
Copy Markdown

kibanamachine commented Mar 10, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3004/

@cchaos cchaos merged commit be10d8a into elastic:master Mar 10, 2020
@anishagg17 anishagg17 mentioned this pull request Mar 10, 2020
Merged
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cchaos cchaos cchaos approved these changes

@myasonik myasonik myasonik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anishagg17 @kibanamachine @myasonik @thompsongl @cchaos