Skip to content

Adding automated accessibility tests for layout pages#2995

Merged
thompsongl merged 2 commits intoelastic:masterfrom
ashikmeerankutty:test/a11y-test
Mar 9, 2020
Merged

Adding automated accessibility tests for layout pages#2995
thompsongl merged 2 commits intoelastic:masterfrom
ashikmeerankutty:test/a11y-test

Conversation

@ashikmeerankutty
Copy link
Copy Markdown
Contributor

@ashikmeerankutty ashikmeerankutty commented Mar 6, 2020

Summary

Makes progress on #2679

Adding an automated assessability test for layout pages.

Pages

Guidelines

  • Writing

Layout

  • Accordion
  • Bottom Bar
  • Flex
  • Flyout
  • Header
  • Horizontal Rule
  • Modal
  • Nav Drawer
  • Page
  • Panel
  • Popover
  • Spacer

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 6, 2020

jenkins test this

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 6, 2020

@ashikmeerankutty I hope this is OK — I edited your PR description so it doesn't automatically close the parent ticket and I added the guidelines writing page as you have that covered.

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_2995/

@myasonik
Copy link
Copy Markdown
Contributor

myasonik commented Mar 6, 2020

@ashikmeerankutty How would you feel about merging this as and opening a new PR for any future work you want to do in this area?

With the speed that EUI moves, I'd prefer to merge these as quickly as possible even for small chunks at a time.

@ashikmeerankutty
Copy link
Copy Markdown
Contributor Author

How would you feel about merging this as and opening a new PR for any future work you want to do in this area?

@myasonik That would be better.

@ashikmeerankutty ashikmeerankutty changed the title [WIP] Adding automated accessibility tests for layout pages Adding automated accessibility tests for layout pages Mar 7, 2020
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @ashikmeerankutty

Thanks!

@thompsongl thompsongl merged commit feb59d7 into elastic:master Mar 9, 2020
@ashikmeerankutty ashikmeerankutty deleted the test/a11y-test branch April 15, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants