EuiCodeEditor: added theme prop to documentation, added test for theme#2970
Merged
thompsongl merged 5 commits intoelastic:masterfrom Mar 3, 2020
Merged
EuiCodeEditor: added theme prop to documentation, added test for theme#2970thompsongl merged 5 commits intoelastic:masterfrom
thompsongl merged 5 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cchaos
suggested changes
Mar 3, 2020
thompsongl
suggested changes
Mar 3, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Thanks for the docs improvement, @anishagg17
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Contributor
Author
|
changes have been made @thompsongl @cchaos |
Contributor
|
jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2970/ |
Contributor
|
jenkins test this |
thompsongl
approved these changes
Mar 3, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @anishagg17
Just an FYI, the brace references here will need to be updated if #2967 merges with the react-ace version bump
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2970/ |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2969
added theme prop to documentation, added test for theme
Checklist