fixes #721 : added context change to accordin in docs-view#2939
fixes #721 : added context change to accordin in docs-view#2939snide merged 12 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@myasonik any recommendations here? In its current configuration, VoiceOver doesn't re-read the updated button text; throwing My gut says we'd need to track focus and only apply aria-live to the focused button, which doesn't seem worth the effort on this small docs section. |
myasonik
left a comment
There was a problem hiding this comment.
I actually think this is fine. The expectation is that the button worked and the user can choose to reread it if they choose to and get more clarity.
To really become a stellar example, I added a couple of code comments. To summarize:
- we add
aria-controlsto the button and point them to the list of items (aria-controlsdoesn't have stellar support so it can't be relied on but it also don't hurt so there's really only upside though limited) - we add
aria-describedbyto the button to explain the current state (the description can also be reread separately from the current item which may be an easier shortcut for some users)
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
Co-Authored-By: Michail Yasonik <michail@yasonik.com>
|
@myasonik Changes Done 👍 |
|
Thanks for the PR @anishagg17 |
Summary
Fixes: #721
added context change to accordin in docs-view
Screenshot
Checklist