adds react-autosize type from recent update#2930
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Feb 27, 2020
Merged
adds react-autosize type from recent update#2930chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall merged 2 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
thompsongl
suggested changes
Feb 26, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Thanks for following up!
@chandlerprall also noticed that @types/react-input-autosize should be in dependencies instead of devDependencies because it becomes a production dependency in eui.d.ts.
Would you might making the change here?
to reflect that fact that, as of the ComboBox -> TypeScript in elastic#2838 it is now actually a prod dependency
e8467e6 to
353a01f
Compare
Contributor
Author
|
wow great catch @chandlerprall! fixed in 353a01f |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a followup from #2838 (comment)
TLDR; The upstream was missing a type that required us to
@ts-ignore, but I made a PR for a fix to the upstream, which just landed today, which means that we can remove the ignore and keep this codebase cleaner.