Skip to content

Add Cheer glyph to EuiIcon#2814

Merged
gjones merged 7 commits intoelastic:masterfrom
gjones:2813-Add-cheer-icon
Jan 31, 2020
Merged

Add Cheer glyph to EuiIcon#2814
gjones merged 7 commits intoelastic:masterfrom
gjones:2813-Add-cheer-icon

Conversation

@gjones
Copy link
Copy Markdown
Contributor

@gjones gjones commented Jan 31, 2020 •
edited
Loading

Summary

Related to #2813
We're looking to add an icon that communicates an announcement, this is one that our team came up with.

Screenshot 2020-01-31 at 10 50 07

Screenshot 2020-01-31 at 10 50 14

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

cc @kaleighflynn

@gjones gjones requested a review from cchaos January 31, 2020 15:27
@gjones gjones added the icons label Jan 31, 2020
@gjones gjones self-assigned this Jan 31, 2020
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Jan 31, 2020 •
edited
Loading

😎 Nice.

I pulled the icon down and put it onto a pixel grid and it looks like the icon uses several line types (some rounded caps, some not) and there are lines that could be aligned to the pixel grid but aren't. This will make them very fuzzy on non-retina screens. If you need some help adjusting the icon let us know.

Screen Shot 2020-01-31 at 11 35 52 AM

@gjones
Copy link
Copy Markdown
Contributor Author

gjones commented Jan 31, 2020

If you need some help adjusting the icon let us know.

If possible, that would be great, I'm happy to zoom and go over it or if its quick and easy, and you don't mind, I'm also happy for you to clean it up.

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Jan 31, 2020

I'll take a stab for you.

@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Jan 31, 2020

It is quite difficult to get a rotated triangle with rounded corners to align to the pixel grid. I did the best I could there, but most of the other lines and dots do now align and all use the same rounded corners.

Screen Shot 2020-01-31 at 12 34 33 PM

@gjones
Copy link
Copy Markdown
Contributor Author

gjones commented Jan 31, 2020

Thanks @cchaos looks great!

More confetti like than lines
162455d 
To try to remove the carrot likeness
@cchaos
Copy link
Copy Markdown
Contributor

cchaos commented Jan 31, 2020

Talked with @gjones about it a bit more and decided to make some changes to the confetti portion to try to remove the carrot likeness.

Screen Shot 2020-01-31 at 15 01 10 PM

Screen Shot 2020-01-31 at 15 00 24 PM

Screen Shot 2020-01-31 at 15 00 30 PM

cchaos
cchaos approved these changes Jan 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@gjones gjones merged commit 15cf8f4 into elastic:master Jan 31, 2020
@thompsongl thompsongl mentioned this pull request Feb 3, 2020
Closed
@thompsongl thompsongl mentioned this pull request Feb 11, 2020
Merged
@elizabetdev elizabetdev mentioned this pull request Jul 14, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cchaos cchaos cchaos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gjones gjones

Labels

icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gjones @cchaos