Support parenthesis in EuiSearchBar values#2791
Merged
chandlerprall merged 4 commits intoelastic:masterfrom Feb 3, 2020
Merged
Support parenthesis in EuiSearchBar values#2791chandlerprall merged 4 commits intoelastic:masterfrom
chandlerprall merged 4 commits intoelastic:masterfrom
Conversation
chandlerprall
commented
Jan 24, 2020
| phrase | ||
| = '"' space? phrase:( | ||
| phraseWord? (space phraseWord)* { return unescapeValue(text()); } | ||
| (phraseWord+)? (space phraseWord+)* { return unescapeValue(text()); } |
Contributor
Author
There was a problem hiding this comment.
Expanding phraseWord (below) with parenthesis support, instead of adding them to wordChar, means that the parenthesis is grouped in a different phraseWord than the rest of the phrase; this line's change allows multiple phaseWords to exist next to each other without spaces separating
thompsongl
approved these changes
Jan 24, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM; tested locally.
Needs a changelog entry
pugnascotia
approved these changes
Jan 27, 2020
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
I checked out the branch, seems to work as advertised 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2788
Adds support for
(and)inEuiSearchBar's expressions when part of a phrase or escaped.Example
")" \((owner:"(" OR owner:\))owner:"dewey (Jr)"Parenthesis can optionally be escaped within a phrase as well:
owner:"dewey \(Jr\)"/cc @pugnascotia for pegjs experience and @bevacqua for
EuiSearchBarexperience, as optional reviewersChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes