Merged
Conversation
chandlerprall
approved these changes
Jan 24, 2020
snide
approved these changes
Jan 24, 2020
Contributor
snide
left a comment
There was a problem hiding this comment.
Ran locally and checked the code and the output of the SVGs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #579
When PR #2554 was merged we couldn't use aria-labelledby because the SVGR at that time didn't allow to specify an id for the title tag.
After requesting a new SVGR feature to allow a title id, it was finally merged.
This PR updates the package @svgr/core to the latest version so we can specify a title id to use with the aria-labelledby. Some logic was changed and icons were generated again to include the new SVGR feature.
The other task remaining on #579, translating the icon names, doesn't make sense anymore because we are not using the icon name as a default title.
Checklist