Improve compressed EuiPagination#2779
Conversation
|
Love the VoiceOver gif ❤️ |
snide
left a comment
There was a problem hiding this comment.
Don't forget to check mobile screen resolutions here.
|
Removed hideOnMobile. Screenshot at iPhone X screen size:
|
snide
left a comment
There was a problem hiding this comment.
This fixes the issue and looks good to merge. I think we might want to eventually get rid of the media queries and instead auto-apply the compressed views based upon a resize observer, but there's no hurry to make that change in this PR.
|
@chandlerprall Mind giving this a quick check. I think @andreadelrio addressed all your feedback and this looks good to merge? |
chandlerprall
left a comment
There was a problem hiding this comment.
One more change requested, for better localization support.
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Pulled & tested locally. Thanks @andreadelrio !
Summary
I've added the current page and a "jump to last page" link to the compressed version of
EuiPagination. See before and after screenshots belowBefore
After
EuiPaginationusing VoiceOver.Fixes #606
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [x] Checked for accessibility including keyboard-only and screenreader modes