Fix EuiFieldSearch's onChange call so it is always called with the Event#2764
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Jan 16, 2020
Merged
Conversation
thompsongl
reviewed
Jan 15, 2020
Contributor
There was a problem hiding this comment.
Confirmed that the changes still clear the search text (including IE11) without error.
I did notice, though, that the clear button remains after being clicked. Previously, the button would be removed. My guess is that previously, the value was being set to null/undefined and now it's '' but the logic remained.
Contributor
Author
|
Great catch! Turns out nothing I originally wrote did anything of value. Refactored & pushed. |
Contributor
|
jenkins test this |
thompsongl
approved these changes
Jan 15, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Works for me; tested in IE11
Contributor
|
Awesome! Thanks for bringing a fix so quickly! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2763
When adding a clear button to
EuiSearchField, the call signature foronChangewas modified. This changes the call to always provide the change event to the handler.This should make it into the Kibana 7.6 branch as a bug fix.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests