Created a euiPaletteColorBlindBehindText variant of the color blind palette#2750
Merged
cchaos merged 17 commits intoelastic:masterfrom Jan 10, 2020
Merged
Created a euiPaletteColorBlindBehindText variant of the color blind palette#2750cchaos merged 17 commits intoelastic:masterfrom
euiPaletteColorBlindBehindText variant of the color blind palette#2750cchaos merged 17 commits intoelastic:masterfrom
Conversation
added 12 commits
January 8, 2020 17:16
1. Created SASS map for viz palette 2. Removed duplicated colors from other themes and use dist folder json instead 3. Created a SASS function to convert vis palette for use behind text
- $euiColorVisColors -> $euiPaletteColorBlind - SASS map now is a nested map containing direct hexes for both graphic and behindText variants - Created new vars for each behindText variant - Got rid of temp color function
added 2 commits
January 9, 2020 18:05
Contributor
|
Looking now! Started yesterday evening and forgot to get back on it! |
ryankeairns
reviewed
Jan 10, 2020
ryankeairns
approved these changes
Jan 10, 2020
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM, just a single comment.
I like the theme cleanup and the moving of commonly used bits to /services!
This was referenced Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds another palette called
euiPaletteColorBlindBehindText()for use in places like EuiBadgeAs mentioned in #2455, we can increase the brightness of the color blind palette when using it with text. This creates an automatic palette for this use case.
It also updates the SASS by creating a new SASS map with both
graphicandbehindTextvariants.In the color guidelines page, the example has been updated to import the palette from JS and allowing the user to toggle between variants.
This palette is now being used directly by EuiBadge, EuiAvatar, EuiLoadingChart, and EuiComboBox's examples.
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Checked for breaking changes and labeled appropriately