Lighten hollow badge border in dark mode#2746
Merged
ryankeairns merged 4 commits intoelastic:masterfrom Jan 9, 2020
Merged
Conversation
cchaos
approved these changes
Jan 9, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM, I just looked at screenshot and code though. Seems straight forward.
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
This was referenced Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2744
Summary
After the recent badge color update, the hollow badge border became hard to see in dark mode. This PR adds some tint to lighten the border when in dark mode. Similar to the light version, the border remains more subtle than the text.
Before
After
Checklist