Allow <Fragment />as EuiNavDrawer children#2710
Merged
thompsongl merged 4 commits intoelastic:masterfrom Jan 2, 2020
Merged
Conversation
myasonik
approved these changes
Dec 20, 2019
Contributor
myasonik
left a comment
There was a problem hiding this comment.
Should there be a test added for this?
chandlerprall
approved these changes
Dec 26, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, thanks for the tests!
Contributor
|
I think this approach is fine - if we need to mess with it again it'd probably be better to move this into a React context defined by EuiNavDrawer which EuiNavDrawerGroup consumes and pulls the expand function from. |
Contributor
Author
|
jenkins test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2709. Kibana's navDrawer implementation is shifting to take further advantage of nested flyouts. It's likely that the menus will be constructed and composed outside the
renderfn, and defined with a wrapping<React.Fragment>element.Checklist
- [ ] Check against all themes for compatability in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes