Skip to content

Added nested glyph to EuiIcon#2707

Merged
cchaos merged 2 commits intoelastic:masterfrom
cchaos:nested_icon
Dec 20, 2019
Merged

Added nested glyph to EuiIcon#2707
cchaos merged 2 commits intoelastic:masterfrom
cchaos:nested_icon

Conversation

@cchaos
Copy link
Copy Markdown
Contributor

@cchaos cchaos commented Dec 19, 2019

Fixes elastic/kibana#49842

Mainly to be used in Kibana as an ES nested field type.

Screen Shot 2019-12-19 at 17 57 52 PM

Screen Shot 2019-12-19 at 17 57 06 PM

Screen Shot 2019-12-19 at 17 57 14 PM

Checklist

  • Check against all themes for compatability in both light and dark modes
  • [ ] Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@cchaos cchaos changed the title Added nested glyph to EuiIcon Added nested to EuiIcon Dec 19, 2019
@cchaos cchaos changed the title Added nested to EuiIcon Added nested glyph to EuiIcon Dec 19, 2019
Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code and in my non-retina browser.

Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🔤

@cchaos cchaos merged commit 32b7bef into elastic:master Dec 20, 2019
@cchaos cchaos deleted the nested_icon branch December 20, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show an icon for nested fields in discover

3 participants