Added EuiFormFieldset and EuiFormLegend components#2706
Merged
cchaos merged 8 commits intoelastic:masterfrom Jan 3, 2020
Merged
Added EuiFormFieldset and EuiFormLegend components#2706cchaos merged 8 commits intoelastic:masterfrom
EuiFormFieldset and EuiFormLegend components#2706cchaos merged 8 commits intoelastic:masterfrom
Conversation
added 4 commits
December 19, 2019 17:13
|
|
||
| import { EuiFormFieldset } from './form_fieldset'; | ||
|
|
||
| describe('EuiFormFieldset', () => { |
Contributor
There was a problem hiding this comment.
Both of these tests should provide children as well so the snapshot can help catch any regression there.
chandlerprall
approved these changes
Jan 2, 2020
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Pulled & tested locally
Contributor
|
jenkins test this flaky test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support the a11y fixes for radio and checkbox groups, I needed to create fieldset and legend components for re-usability.
It also moves some of the form label styles to a global mixin.
Checklist
[ ] Checked for breaking changes and labeled appropriately