EuiSuggest: converted to Typescript#2692
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
This one demanded a lot of effort... Although it passed tests, I'm sure it needs some polishing |
chandlerprall
left a comment
There was a problem hiding this comment.
Couple of comments/requests, but overall this looks great. Definitely like the Component -> FunctionComponent conversion!
|
Oh, this also needs to export the Eui*Props types from src/components/suggest/index.ts |
|
Don't know if I got it all right... if you could take a new look I'd appreciate |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes look correct - one more request I just saw/added and a previous one was missed, as GitHub's interface hid it behind a "load more conversations" button #2692 (comment)
chandlerprall
left a comment
There was a problem hiding this comment.
One last ask, then this should be good to go
|
jenkins test this |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled & tested locally
Summary
Closes #2644
Converted
EuiSuggestto Typescript.Checklist