EuiErrorBoundary: converted to Typescript#2690
EuiErrorBoundary: converted to Typescript#2690chandlerprall merged 11 commits intoelastic:masterfrom
Conversation
|
One thing is, I couldn't convert the component to a Functional Component because React Hooks does not have a hook for |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@chandlerprall could you take a look if I got it all? |
chandlerprall
left a comment
There was a problem hiding this comment.
Updates look good! Few last items from a final pass and this should be good to merge
- added a request around the
Errorinterface - changelog entry needs to be moved back to the top section, as we just had a release which moved things around
- delete src/components/error_boundary/index.d.ts
- reference to the index.d.ts needs to be removed from
Line 4 in 3bf9df5
|
Think I got it all |
|
jenkins test this |
chandlerprall
left a comment
There was a problem hiding this comment.
One last request - please export EuiErrorBoundaryProps from src/components/error_boundary/index.ts
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, pulled and tested locally
|
Thank you once again, @ffknob ! |
Summary
Closes #2661
Converted
EuiErrorBoundaryto Typescript.Checklist