EuiCodeEditor: added data-test-subj property#2689
Merged
thompsongl merged 4 commits intoelastic:masterfrom Dec 19, 2019
Merged
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
This was referenced Dec 18, 2019
thompsongl
suggested changes
Dec 18, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
This works great, @ffknob!
We can simplify a bit, though, and get closer to EUI patterns:
Contributor
|
jenkins test this |
Contributor
|
@ffknob Conflict needs to be resolved and then we'll get this merged |
Contributor
|
jenkins test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2680
Added
data-test-subjproperty toEuiCodeEditorcomponent.Checklist