EuiFieldText: converted to Typescript#2688
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Just one thing: I had to deal with |
chandlerprall
left a comment
There was a problem hiding this comment.
Also needs:
- remove src/components/form/field_text/index.d.ts
- remove reference at
eui/src/components/form/index.d.ts
Line 5 in 705de53
chandlerprall
left a comment
There was a problem hiding this comment.
Lastly, needs to touch a couple more files,
- remove src/components/form/field_text/index.d.ts
- remove reference at
eui/src/components/form/index.d.ts
Line 5 in 705de53
then this should be good to go
|
Had to commit skiping |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, pulled & tested locally
|
jenkins test this |
Hmm, interesting. I checked out your branch out and don't see any issues (CI passed as well). If you continue getting this on other branches please bring it up again. |
Summary
Closes #2648
Converted
EuiFieldTextto Typescript.Checklist