Skip to content

EuiFieldNumber: converted to Typescript#2685

Merged
thompsongl merged 6 commits intoelastic:masterfrom
ffknob:convert-EuiFieldNumber-to-TS
Dec 19, 2019
Merged

EuiFieldNumber: converted to Typescript#2685
thompsongl merged 6 commits intoelastic:masterfrom
ffknob:convert-EuiFieldNumber-to-TS

Conversation

@ffknob
Copy link
Copy Markdown
Contributor

@ffknob ffknob commented Dec 17, 2019 •
edited
Loading

Summary

Closes #2652
Converted EuiFieldNumber to Typescript.

Checklist

  • Check against all themes for compatability in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 17, 2019

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

This was referenced Dec 17, 2019
Closed
Open
@ffknob
Copy link
Copy Markdown
Contributor Author

ffknob commented Dec 17, 2019

I left some code commented. I don't know if the goal of that numberOrEmptyString function was to really send some error message back, or only to test the value for number | ''.

If the validation should still be in place, how do you suggest I use this function? (I don't think I can use it to type the attribute in the interface, as it was the case with propTypes definitions)

@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Dec 18, 2019

I don't know if the goal of that numberOrEmptyString function was to really send some error message back, or only to test the value for number | ''.

@chandlerprall, what do you think? I'd be comfortable removing numberOrEmptyString entirely and relying on TypeScript for feedback. number | '' is pretty clear.

@chandlerprall
Copy link
Copy Markdown
Contributor

chandlerprall commented Dec 18, 2019 •
edited
Loading

Using number | '' and removing numberOrEmptyString sounds good to me!

thompsongl
thompsongl suggested changes Dec 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar changes to what you did with EuiFieldPassword:

Remove the TS reference in src/components/form/index.d.ts line 2:
/// <reference path="./field_number/index.d.ts" />
and then delete the ./field_number/index.d.ts file as it is no longer needed

@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Dec 19, 2019

jenkins test this

1 similar comment
@thompsongl
Copy link
Copy Markdown
Contributor

thompsongl commented Dec 19, 2019

jenkins test this

@thompsongl thompsongl merged commit 7276c77 into elastic:master Dec 19, 2019
@thompsongl thompsongl mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thompsongl thompsongl thompsongl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EuiFieldNumber needs to be converted to TS

5 participants

@ffknob @elasticmachine @thompsongl @chandlerprall @snide