Remove potentially duplicate EuiPopover id attributes#2667
Merged
thompsongl merged 3 commits intoelastic:masterfrom Dec 13, 2019
Merged
Remove potentially duplicate EuiPopover id attributes#2667thompsongl merged 3 commits intoelastic:masterfrom
EuiPopover id attributes#2667thompsongl merged 3 commits intoelastic:masterfrom
Conversation
chandlerprall
approved these changes
Dec 13, 2019
Contributor
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; verified the removed IDs don't appear useful/used by anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elastic/kibana#50992 highlights a case where duplicate
iderrors can occur withEuiPopover.This removes the
idattributes on cases where the value is not necessary and could produce such errors.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes