Fixes several a11y issues manifesting in Kibana#2411
Merged
snide merged 12 commits intoelastic:masterfrom Oct 11, 2019
Merged
Conversation
snide
suggested changes
Oct 10, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
Thanks for doing this! This is a quick review. I need to check the browser render / sass changes, but figured I could give you some quick stuff.
src/components/date_picker/super_date_picker/date_popover/relative_tab.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/date_popover/relative_tab.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Show resolved
Hide resolved
src/components/date_picker/super_date_picker/quick_select_popover/refresh_interval.js
Outdated
Show resolved
Hide resolved
myasonik
commented
Oct 11, 2019
src/components/date_picker/super_date_picker/quick_select_popover/quick_select.js
Outdated
Show resolved
Hide resolved
…with the designer gods
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several of misc a11y issues showing up in Kibana:
EuiSuperDatePicker(Kibana issue 38794) (this kind of snowballed into improving several things in the vicinity)EuiFormRows that render fields that also render a label end up rendering multiple labels for an input which breaks many assistive tech (this issue was found during the in progress Kibana rollout of automated a11y testing (Kibana issue 43584 )EuiCodeEditors would render with the same ID which breaks many assistive tech (this issue was found during the in progress Kibana rollout of automated a11y testing)Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added documentation examples