Added component prop to EuiPageBody#2410
Merged
andreadelrio merged 4 commits intoelastic:masterfrom Oct 10, 2019
Merged
Conversation
snide
reviewed
Oct 10, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
Some small stuff. Once you fix, LGTM.
CHANGELOG.md
Outdated
| - Added new `EuiColorStops` component ([#2360](https://github.com/elastic/eui/pull/2360)) | ||
| - Added `currency` glyph to 'EuiIcon' ([#2398](https://github.com/elastic/eui/pull/2398)) | ||
| - Migrate `EuiBreadcrumbs`, `EuiHeader` etc, and `EuiLink` to TypeScript ([#2391](https://github.com/elastic/eui/pull/2391)) | ||
| - Added `component` prop to `EuiPageBody` ([#2410](https://github.com/elastic/eui/pull/2410)) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Added `component` prop to `EuiPageBody` ([#2410](https://github.com/elastic/eui/pull/2410)) | |
| - Added `component` prop to `EuiPageBody`, switching the default from `div` to `main` ([#2410](https://github.com/elastic/eui/pull/2410)) |
| children: PropTypes.node, | ||
| className: PropTypes.string, | ||
|
|
||
| component: PropTypes.string, |
Contributor
There was a problem hiding this comment.
Add an autodoc comment above this to say what it does.
snide
approved these changes
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
componentprop toEuiPageBody. Default value ismain, consumer can pass a different html tag if needed.Covers #2359
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox-[X] Props have proper autodocs
- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes-[X] A changelog entry exists and is marked appropriately