Upgrade sidenav search to include sub-section titles#2151
Upgrade sidenav search to include sub-section titles#2151chandlerprall merged 6 commits intoelastic:masterfrom
Conversation
|
Yaaas!!! Is it also possible to add to this PR an auto-scroll of the sidebar content? So when you navigate to a new section it tries to scroll sidebar to have that section at the top? |
| import { GuideThemeSelector } from '../guide_theme_selector'; | ||
|
|
||
| const scrollTo = position => { | ||
| $('html, body').animate( |
There was a problem hiding this comment.
Oh my it's been a while since I've seen $
|
|
done and pushed @cchaos ! |
I don't think so? Open to other opinions though |
It's not a big deal at all. This is already a huge improvement |
thompsongl
left a comment
There was a problem hiding this comment.
Changes LGTM. Works great as tested locallly
|
Saweet! The only other thing is that because the sections are "open" they're indicated via the color blue which I find very distraction when you're just searching. Is it possible to only add The following enhancement is not necessary, but it could be nice to also use the |
|
@cchaos done and done! |
|
Awesome! Sorry, I just still see one oddity. When searching there seems to be a difference in the way level 2 section titles appear if when they have sub-sections versus those that don't. I think they all need to stay that lighter shade of gray. |
|
Updated again! Give scss change a look over, I feel like I abused it a bit. |
cchaos
left a comment
There was a problem hiding this comment.
Just a thing about the class naming. But this is rad!
Summary
This has bugged me for a long time, also closes #2095. Enhances the docs' sidenav search to include subsections.
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] A changelog entry exists and is marked appropriately- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components