Skip to content

Remove nested array in ES Query DSL generation#2133

Merged
chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall:bug/2109-searchbar-query-or-es-dsl
Jul 17, 2019
Merged

Remove nested array in ES Query DSL generation#2133
chandlerprall merged 3 commits intoelastic:masterfrom
chandlerprall:bug/2109-searchbar-query-or-es-dsl

Conversation

@chandlerprall
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall commented Jul 17, 2019

Summary

Fixes #2109, removes the nested array in the bool.must.bool.should location.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@chandlerprall chandlerprall requested a review from bevacqua July 17, 2019 17:13
Copy link
Copy Markdown
Contributor

@bevacqua bevacqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@chandlerprall chandlerprall merged commit a27756d into elastic:master Jul 17, 2019
@chandlerprall chandlerprall deleted the bug/2109-searchbar-query-or-es-dsl branch July 17, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in search bar ES query DSL for top level grouped clauses

2 participants