Allow ESC to propagate if EuiPopover is not open#2089
Merged
thompsongl merged 5 commits intoelastic:masterfrom Jul 8, 2019
Merged
Allow ESC to propagate if EuiPopover is not open#2089thompsongl merged 5 commits intoelastic:masterfrom
EuiPopover is not open#2089thompsongl merged 5 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
(shakes fist at #1999) jenkins test this |
chandlerprall
suggested changes
Jul 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2042, in which a closed
EuiPopoverinside of an openEuiPopoverwill catch theESCkey press and prevent event propagation, preventing the openEuiPopoverfrom closing.More generally, this solution will allow propagation regardless of nesting/location if the
EuiPopoveris not open.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components