Pass EuiSuperSelect's popoverClassName to the popover's panel#2068
Merged
zumwalt merged 3 commits intoelastic:masterfrom Jun 20, 2019
Merged
Pass EuiSuperSelect's popoverClassName to the popover's panel#2068zumwalt merged 3 commits intoelastic:masterfrom
zumwalt merged 3 commits intoelastic:masterfrom
Conversation
c9d2a57 to
7e0748d
Compare
cchaos
reviewed
Jun 20, 2019
| ); | ||
|
|
||
| const popoverPanelClasses = classNames('euiSuperSelect__popoverPanel', { | ||
| [`${popoverClassName}__popoverPanel`]: !!popoverClassName, |
Contributor
There was a problem hiding this comment.
Are the brackets necessary? Shouldn't it just be:
Suggested change
| [`${popoverClassName}__popoverPanel`]: !!popoverClassName, | |
| `${popoverClassName}__popoverPanel`: !!popoverClassName, |
Contributor
Author
There was a problem hiding this comment.
It looks like they’re required for dynamic class names: https://github.com/JedWatson/classnames/blob/master/README.md#dynamic-class-names-with-es2015
Contributor
There was a problem hiding this comment.
Huh, I guess this is the first time we've used this pattern. 👍
cchaos
approved these changes
Jun 20, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM, though is there something you're trying to "fix" about the popover panel that this allows you to do? I know this component is super buggy, so just wondering if we need to be aware of something or need an issue.
Contributor
Author
|
No, not trying to fix anything with this, we just need it for some ill-advised theming 😭 |
Contributor
|
Got it. Whew... 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR passes
EuiSuperSelect'spopoverClassNameto the popover's panel if it exists. This change will make it easier to target elements within the popover panel via CSS selectors.Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] This was checked in dark mode[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components