Update popout icon to external link style#2064
Merged
ryankeairns merged 2 commits intoelastic:masterfrom Jun 20, 2019
Merged
Conversation
a447492 to
cd8768d
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current
popouticon is used as an external link indicator, but it doesn't look like the typical glyph for that purpose. This PR updates it to look like the traditional external link icon.Before and after
Dark mode
Sketch pixel grid
💎Note: see the
popout-external-linkbranch in the EUI 2.0 Abstract project for the Sketch versionChecklist
This was checked in mobileThis was checked in IE11Any props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components