Properly handle Function and TSMethodSignature TS interfaces and type literals#2048
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Jun 17, 2019
Merged
Conversation
pugnascotia
approved these changes
Jun 17, 2019
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
I build the branch and the generated prop type for children looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed that the docs showed proptype warnings for EuiCopy's
children, even though everything was typed & passed correctly. Discovered that theFunctionidentifier and method signatures were not being detected by the TS->proptype script. Added a test case to cover(which should all result in either
PropTypes.funcorPropTypes.func.isRequired)in both
interfaceandtypedefinitions, and confirmed EuiCopy's proptype is now correct.Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components