Feature/1160 search exact match#1843
Merged
chandlerprall merged 12 commits intoelastic:masterfrom Apr 19, 2019
Merged
Conversation
thompsongl
reviewed
Apr 17, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
Makes sense to me. Looks ready for tests and docs
…prall/eui into feature/1160-search-exact-match
Contributor
Author
|
Added tests & documentation, no longer a draft, re-requesting reviews. |
thompsongl
approved these changes
Apr 18, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM. Confirmed locally that exact matching and empty phrasing work as I'd expect.
This was referenced Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #1160, closes #1294, and closes #1855
=, which compliments the existing:partial match operator""Together, these allow searching explicitly for empty tags:
tag=""Created as a draft as I have not written tests yet, wanted to make sure the changes make sense before creating tests & docs.
Also accidentally included the fix for #1855 in this. Thanks to @thompsongl for catching that!
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components