Small accessibility fixes to toasts and combo box#1803
Merged
snide merged 7 commits intoelastic:masterfrom Apr 9, 2019
Merged
Conversation
chandlerprall
suggested changes
Apr 8, 2019
cchaos
reviewed
Apr 8, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Should the toast also still persist if the user has clicked inside it, example is selecting text:
Contributor
Author
|
This is ready for a final review I think. I don't know how to address the text selection stuff, but between the mouse hover and the tabbing inside I think it's good enough to close out that old ticket. |
cchaos
approved these changes
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Easy one while I was cleaning out the backlog. As long as an item within a toast has focus, it will stick around. When you tab out, it will resume the countdown, similar to mouse actions.
Fixes #717
Also added a fixes #1343. Given how direct the combo box is with instruction it seemed like the best thing to do was announce the placeholder in the same way.
Checklist
This was checked in mobileThis was checked in dark modeAny props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyJest tests were updated or added to match the most common scenariosThis required updates to Framer X components