New uptime app icon, deprecation warning for charts#1463
Merged
snide merged 4 commits intoelastic:masterfrom Jan 23, 2019
Merged
New uptime app icon, deprecation warning for charts#1463snide merged 4 commits intoelastic:masterfrom
snide merged 4 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
cc @markov00 about the deprecation warning. |
cchaos
approved these changes
Jan 23, 2019
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Tested locally - everything seems to work fine.
Code mostly LGTM - I had one question.
Also, just checking that we are ok with keeping Series charts (beta) as the text for the route to the charts examples. Should there be a scheduled deprecation warning in the route as well?
Thanks for this, excited to get the icon in ASAP.
Contributor
Author
|
Feedback addressed. Merging after green. |
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coincidentally, both changes are important to the uptime team :)
Checklist
This was checked in mobileThis was checked in IE11This was checked for breaking changes and labeled appropriatelyThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components