Increase default font size of tabs in KUI theme#1244
Merged
cchaos merged 3 commits intoelastic:masterfrom Oct 18, 2018
Merged
Conversation
formgeist
approved these changes
Oct 16, 2018
Contributor
formgeist
left a comment
There was a problem hiding this comment.
LGTM - nice to have some more variables to use, especially for main tab navigation vs. flyout content.
Contributor
Author
|
@snide quick thoughts on this one? |
snide
approved these changes
Oct 18, 2018
Contributor
snide
left a comment
There was a problem hiding this comment.
I think it's fine for now. In 6.6 let's just remove the theme so we don't run into these issues.
Contributor
Author
|
The theme? |
Contributor
|
The K6 theme. I think in 6.6 we should feel pretty safe removing it (aside from the font-family setting). |
Contributor
Author
|
Oh alright! Sounds like a plan! ;) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since Kibana's default font size is 14px, the differences between the small and regular tabs were nil. This creates 2 variables for the tab font sizes and then changes them in the K6_globals.scss file.
Checklist
- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked for breaking changes and labeled appropriately- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios