-
Notifications
You must be signed in to change notification settings - Fork 870
[EuiCopy] Add tooltipProps prop #8382
Copy link
Copy link
Labels
breaking changePRs with breaking changes. (Don't delete - used for automation)PRs with breaking changes. (Don't delete - used for automation)low hanging fruitAn issue, often a bug, that is lower effort and clearly ought to be fixedAn issue, often a bug, that is lower effort and clearly ought to be fixed
Metadata
Metadata
Assignees
Labels
breaking changePRs with breaking changes. (Don't delete - used for automation)PRs with breaking changes. (Don't delete - used for automation)low hanging fruitAn issue, often a bug, that is lower effort and clearly ought to be fixedAn issue, often a bug, that is lower effort and clearly ought to be fixed
Type
Fields
Give feedbackNo fields configured for Enhancement.
Description
The purpose of this task is to add a
tooltipPropsprop to theEuiCopycomponent instead of passing tooltip props flat to the component type. This helps to to distinguish tooltip props from the copy functionality props.It's consistent with other components that consume props to pass to children (e.g. for
EuiSuperUpdateButton(code) orEuiButtonGroupButton(code))Important
Updating the component API will be a breaking change and requires updating implementation usages.
Acceptance criteria
tooltipPropstoEuiCopyand updated it's prop type definitionRollout consideration
Note on impact / scope of rollout: If we make it a breaking change, there is usage in Kibana we would need to update, but it should be limited and we can handle that ourselves as part of the upgrade.