As a follow-up to a recent PR that updates the alert icon and adds a new error icon (#6550), I think it may be wise to consider the following:
- Consider deprecating/removing the
crossInACircleFilled icon for two reasons: 1) It's very close to the new error icon, and 2) it perpetuates a problematic pattern where some EUI icons offer regular/circled/filled variants, which often lead to a lot of interface inconsistencies. I imagine it can be replaced with either a regular cross or error icon, as the context dictates.
- Consider changing the current
alert icon's name to warning. Doing so will make it clearer to developers that we have specific icons to use for error and warning cases.
Curious to know the team's thoughts on these suggestions. Thanks!
As a follow-up to a recent PR that updates the
alerticon and adds a newerroricon (#6550), I think it may be wise to consider the following:crossInACircleFilledicon for two reasons: 1) It's very close to the newerroricon, and 2) it perpetuates a problematic pattern where some EUI icons offer regular/circled/filled variants, which often lead to a lot of interface inconsistencies. I imagine it can be replaced with either a regularcrossorerroricon, as the context dictates.alerticon's name towarning. Doing so will make it clearer to developers that we have specific icons to use for error and warning cases.Curious to know the team's thoughts on these suggestions. Thanks!